Skip to content

eliminate_except: require dim_type #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
inducer merged 1 commit into from
Aug 11, 2026
Merged

eliminate_except: require dim_type #22

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions namedisl/set_like.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,17 +252,19 @@ def eliminate(self,
def eliminate_except(
self,
names_to_keep: Collection[str],
*, cache: Cache | None = None,
*, dim_type: DimType | Literal["all"],
cache: Cache | None = None,
) -> Self:
"Keeps the dimensions, but eliminates constraints."
if isinstance(names_to_keep, str):
raise TypeError("names_to_keep must be a collection of str")

names_to_eliminate = [
name for name in self.space.name_to_dim if name not in names_to_keep
]
if dim_type == "all":
names_to_eliminate = self.space.names
else:
names_to_eliminate = self.space.dim_names(dim_type)

return self.eliminate(names_to_eliminate, cache=cache)
return self.eliminate(names_to_eliminate - set(names_to_keep), cache=cache)

def project_out(self,
names: str | Collection[str],
Expand Down Expand Up @@ -297,7 +299,7 @@ def project_out_except(
raise TypeError("names_to_keep must be a collection of str")

if dim_type == "all":
names_to_project_out = self.space.names - set(names_to_keep)
names_to_project_out = self.space.names
else:
names_to_project_out = self.space.dim_names(dim_type)

Expand Down
Loading