Drop arguments to pybind none for due to backward incompatible changes in nanobind 3 - #221
Merged
Merged
Conversation
Owner
|
Thanks! The pyopencl changes are inducer/pyopencl#916. Note that this islpy also needs a recent loopy, see #213. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #220
I have verified this by building locally and running CI on my fork. However, I have no actual knowledge of the codebase, and in particular I do not understand the implications of passing the
trueargument tononein pybind 2.x.pyopenclmay need a similar fix (as highlighted by theTests for downstream project loopyCI job failing on my fork), but I didn't need that for firedrake's stack so I didn't prepare a similar patch there.