[FIX] 1차 QA 수정사항 반영 (온보딩/프로필) - #219
Open
ckals413 wants to merge 6 commits into
Hidden character warning
The head ref may contain hidden characters: "FLT-27-1\ucc28-qa-\uc784\ucc28\ubbfc"
Open
Conversation
Contributor
📝 WalkthroughWalkthrough온보딩 흐름을 약관 → 콘텐츠 → 프로필 → 완료 순서로 변경했습니다. 닉네임 결과는 일회성 토스트 이벤트로 전달합니다. 프로필 이스터에그 탈퇴 기능과 애플리케이션 재시작 처리를 제거했습니다. Changes온보딩 흐름 변경
프로필 이스터에그 탈퇴 제거
Estimated code review effort: 3 (Moderate) | ~25 minutes Sequence Diagram(s)sequenceDiagram
participant Terms
participant Content
participant Profile
participant ViewModel
participant Done
Terms->>Content: 약관 동의 완료
Content->>Profile: 콘텐츠 선택 완료
Profile->>ViewModel: 닉네임 검증 요청
ViewModel-->>Profile: ShowNicknameToast 이벤트
Profile->>Done: 프로필 완료
Possibly related PRs
Suggested labels: Suggested reviewers: Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@app/src/main/java/com/flint/presentation/onboarding/OnboardingViewModel.kt`:
- Around line 149-162: In the result-handling flow around _profileEvent.emit,
compare the nickname associated with the availability response to the current
input before updating state or emitting ShowNicknameToast. Ignore stale
responses when they differ, and apply the existing success/failure behavior only
when the response matches the current nickname.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: a9604dc1-98ff-405e-acf4-e643ae4d9e27
📒 Files selected for processing (10)
app/src/main/java/com/flint/presentation/onboarding/OnboardingContentScreen.ktapp/src/main/java/com/flint/presentation/onboarding/OnboardingProfileScreen.ktapp/src/main/java/com/flint/presentation/onboarding/OnboardingTermsScreen.ktapp/src/main/java/com/flint/presentation/onboarding/OnboardingViewModel.ktapp/src/main/java/com/flint/presentation/onboarding/event/OnboardingProfileEvent.ktapp/src/main/java/com/flint/presentation/onboarding/navigation/OnboardingNavigation.ktapp/src/main/java/com/flint/presentation/profile/ProfileScreen.ktapp/src/main/java/com/flint/presentation/profile/ProfileViewModel.ktapp/src/main/java/com/flint/presentation/profile/component/ProfileTopSection.ktapp/src/main/java/com/flint/presentation/profile/sideeffect/ProfileSideEffect.kt
💤 Files with no reviewable changes (4)
- app/src/main/java/com/flint/presentation/profile/sideeffect/ProfileSideEffect.kt
- app/src/main/java/com/flint/presentation/profile/ProfileViewModel.kt
- app/src/main/java/com/flint/presentation/profile/component/ProfileTopSection.kt
- app/src/main/java/com/flint/presentation/profile/ProfileScreen.kt
Contributor
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In
`@app/src/main/java/com/flint/presentation/onboarding/OnboardingContentScreen.kt`:
- Around line 139-142: Update the onboarding title Text in
OnboardingContentScreen to use the complete phrase without a forced newline,
allowing it to remain on one line when it fits within the 16dp horizontal
padding and wrap naturally only when space is insufficient.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: ce059229-a33f-416d-8a2a-c12106ae0c31
📒 Files selected for processing (2)
app/src/main/java/com/flint/presentation/onboarding/OnboardingContentScreen.ktapp/src/main/java/com/flint/presentation/onboarding/OnboardingViewModel.kt
🚧 Files skipped from review as they are similar to previous changes (1)
- app/src/main/java/com/flint/presentation/onboarding/OnboardingViewModel.kt
Comment on lines
139
to
142
| Text( | ||
| text = if (useMultiLine) { | ||
| "${nickname}님이\n좋아하는 작품\n7개를 골라주세요" | ||
| } else { | ||
| "${nickname}님이 좋아하는 작품\n7개를 골라주세요" | ||
| }, | ||
| text = "내 취향에 가까운 작품\n7개를 골라주세요", | ||
| color = FlintTheme.colors.white, | ||
| style = FlintTheme.typography.display2M28, |
Contributor
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
제목을 항상 두 줄로 강제하지 마세요.
text의 \n은 가용 폭과 관계없이 줄바꿈을 발생시킵니다. PR 요구사항은 좌우 16dp 영역에서 한 줄을 우선하고 필요한 경우에만 수동 줄바꿈하는 것입니다. 현재 구현은 태블릿이나 가로 화면처럼 전체 문구가 들어가는 환경에서도 두 줄로 표시됩니다. 줄바꿈 없는 전체 문구를 기본값으로 사용하고, 가용 폭이 부족할 때만 줄바꿈하도록 수정하세요.
제안
- text = "내 취향에 가까운 작품\n7개를 골라주세요",
+ text = "내 취향에 가까운 작품 7개를 골라주세요",
+ maxLines = 2,📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| Text( | |
| text = if (useMultiLine) { | |
| "${nickname}님이\n좋아하는 작품\n7개를 골라주세요" | |
| } else { | |
| "${nickname}님이 좋아하는 작품\n7개를 골라주세요" | |
| }, | |
| text = "내 취향에 가까운 작품\n7개를 골라주세요", | |
| color = FlintTheme.colors.white, | |
| style = FlintTheme.typography.display2M28, | |
| Text( | |
| text = "내 취향에 가까운 작품 7개를 골라주세요", | |
| maxLines = 2, | |
| color = FlintTheme.colors.white, | |
| style = FlintTheme.typography.display2M28, |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In
`@app/src/main/java/com/flint/presentation/onboarding/OnboardingContentScreen.kt`
around lines 139 - 142, Update the onboarding title Text in
OnboardingContentScreen to use the complete phrase without a forced newline,
allowing it to remain on one line when it fits within the 16dp horizontal
padding and wrap naturally only when space is insufficient.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📮 관련 이슈
📌 작업 내용
Summary by CodeRabbit
새 기능
개선 사항