Update to new slice & dice version#187
Draft
PssbleTrngle wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
did a lot of refactoring in the latest version, so I thought it would be fair to update the slice & dice compat here myself.
I've removed the mixin into the
SlicerArmInteractionTypebecause I check there forinstanceof SlicerBlocknow instead of the one specific instance, so it should work out of the box.I've still marked this as a draft, because I've used the
-SNAPSHOTversion that I've not released yet, I'll mark this as ready as soon as that is released.