fix(app): copy css.d.ts into Docker builder stage#2625
Conversation
The TypeScript 6 upgrade (#2617) added packages/app/css.d.ts to type side-effect stylesheet imports (e.g. '@mantine/core/styles.css') and updated the Dockerfile to copy the new mdx.d.ts, but omitted css.d.ts. The builder stage assembles app source from selective COPY statements (src, pages, public, styles, types) that don't include package-root .d.ts files, so css.d.ts never reached the build and the production image failed type checking with TS2882. Copy it alongside mdx.d.ts.
🦋 Changeset detectedLatest commit: 8acc192 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
🔴 Tier 4 — CriticalTouches auth, data models, config, tasks, OTel pipeline, ClickHouse, or CI/CD. Why this tier:
Review process: Deep review from a domain expert. Synchronous walkthrough may be required. Stats
|
Greptile SummaryThis PR fixes the app Docker production build after the TypeScript upgrade.
Confidence Score: 5/5This looks safe to merge.
Important Files Changed
Reviews (2): Last reviewed commit: "chore: shorten changeset to one line" | Re-trigger Greptile |
E2E Test Results✅ All tests passed • 234 passed • 3 skipped • 1578s
Tests ran across 4 shards in parallel. |
Deep Review✅ No critical issues found. The one-line 🟡 P2 -- recommended
🔵 P3 nitpicks (1)
Reviewers (4): correctness, testing, maintainability, project-standards. Testing gaps: No PR-time guard verifies the production Dockerfile's app |
The production Docker image failed to build after the TypeScript 6 upgrade (#2617) with
TS2882: Cannot find module or type declarations for side-effect import of '@mantine/core/styles.css'.That upgrade added
packages/app/css.d.ts(the ambientdeclare module '*.css'that types side-effect stylesheet imports) and updated the Dockerfile to copy the newmdx.d.ts— but omittedcss.d.ts. The builder stage assembles app source from selectiveCOPYstatements (src,pages,public,styles,types) that don't include package-root.d.tsfiles, socss.d.tsnever reached the build. Local lint and CI type-checks passed because the file is present there; only the Docker build, with its selective copies, missed it.Fix: copy
css.d.tsinto the builder stage alongsidemdx.d.ts.