fix(gateway): add CLMM add/remove liquidity methods, send explicit slippage_pct=0#23
Open
fengtality wants to merge 1 commit into
Open
fix(gateway): add CLMM add/remove liquidity methods, send explicit slippage_pct=0#23fengtality wants to merge 1 commit into
fengtality wants to merge 1 commit into
Conversation
…ippage_pct=0 - gateway_clmm: add add_liquidity() and remove_liquidity() (POST /gateway/clmm/add and /gateway/clmm/remove) which were missing entirely - gateway_clmm/gateway_swap: slippage_pct=0 was dropped as falsy and replaced with the 1.0 default; use `is not None` checks - bump version to 1.5.4 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Ko4KsGwUaHjqiRTYon31Li
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
gateway_clmm: addadd_liquidity()andremove_liquidity()— the client had no methods forPOST /gateway/clmm/addandPOST /gateway/clmm/removeat all.slippage_pct=0was dropped as falsy (if slippage_pct/or "1.0") and silently replaced with the 1.0 default ingateway_swap.quote_swap,gateway_swap.execute_swap, andgateway_clmm.open_position; now usesis not None.Note:
feat/market-data-24h-volumes(#pending) also bumps to 1.5.4 — whichever merges second should re-bump to 1.5.5 before publishing.Test plan
Verified live against hummingbot-api + Gateway on 15888:
remove_liquidity()on a bogus position address reaches/gateway/clmm/removeand returns Gateway's real "Position not found" 404; swap quotes withslippage_pct=0round-trip as"0".🤖 Generated with Claude Code
https://claude.ai/code/session_01Ko4KsGwUaHjqiRTYon31Li