-
Notifications
You must be signed in to change notification settings - Fork 0
fix(review): omit the full diff rather than truncate it #36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
54c15b8
fix(review): omit the full diff rather than truncate it
zfarrell f8d4e4f
fix(review): bound the blocks written above the diff
zfarrell 2028203
fix(review): measure block shares against the context, not the prompt
zfarrell 749c3bf
fix(review): denominate the log allowance in the context too
zfarrell 895cf18
fix(review): leave headroom in the sum of the block shares
zfarrell File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: "every fetched block bounded" is one block short, and the same claim is now in tests/context-step-test.sh:804.
## Commits(scripts/gather-review-context.sh:485) is written straight from$COMMITSwith no cap — nocap_file_escaped, no line cap. (not blocking)It is the last fetched block in that position. The pulls/
{n}/commits endpoint tops out at 250 commits, so the ordinary ceiling is ~15 KB at a 60-byte line — already a quarter of the context on a maxed-threads run — but the line is\(.sha[0:8]) \(.commit.message | split("\n")[0])and a git subject has no length bound, so the real ceiling is whatever the author writes. It sits above## Full difflike the changed-file list did, so an overflow there is paid for by the omission notice and the conversation, which is the argument this PR just used to cap the other two.Either give it the same treatment as
FILES_FILE— it is three lines andNOTICE_FILEShas a sibling shape — or narrow the sentence to name it alongside the PR body. The claim is load-bearing for "the tail cut is a backstop rather than the ordinary path", so it is worth being exactly true.