ci: macOS dory backend smoke spike workflow#77
Open
patrickleet wants to merge 8 commits into
Open
Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
patrickleet
force-pushed
the
feat/cluster-backend-abstraction
branch
from
4297cd2 to
29b3db5
Compare
patrickleet
force-pushed
the
ci/dory-macos-smoke
branch
from
e571900 to
292c5e5
Compare
Collaborator
Author
Colima lessons appliedColima smoke is green on public GHA (run 29172450420). Ported what transfers to dory: Shared
|
Clone+build patrickleet/dory @ feat/hops-local-integration in CI, wait for engine.sock, then kind-parity hops smoke with --backend dory. workflow_dispatch / non-required until public GHA can boot the engine. Implements [[tasks/hops-cli-dory-macos-smoke]] under [[tasks/hops-cli-macos-backend-smoke]].
Assert clone+build install contract and kind-parity steps in the shipped on-pr-dory-smoke.yaml.
Bring shared start hardness (CRD Established waits, apply retries, longer Crossplane/registry waits) from the green colima path, and harden the dory workflow: settle CoreDNS before registry pods, 420s Ready, stop/start rollout restart, failure dump, and ECR pull retries. Structural tests lock the contract in.
patrickleet
force-pushed
the
ci/dory-macos-smoke
branch
from
e3d6e42 to
7c9c7ef
Compare
workflow_dispatch only works once the file exists on the default branch; enable pull_request (still non-required) so #77 can actually run dory-smoke.
Public GHA cannot run dory-hv (no nested virt for native engine; app never creates ~/.dory). Pin macos-15-intel, still clone+build dory for scripts/, try the app briefly, then expose Colima docker as ~/.dory/engine.sock so hops local --backend dory can complete kind-parity smoke.
dory enable exits 3 when ports/registry binds drift. hops just wrote the desired config; auto-retry once with --recreate so local start applies it. CI: skip native engine wait on Intel, set DORY_ENGINE_SOCK, disable k8s first.
After dory stop/start, nodes can be Ready while openapi/v2 still times out and helm upgrade fails. Retry helm with wait_for_kubernetes between attempts; CI pause briefly after stop before start.
docker stop of dory-k8s often leaves k3s stuck past dory's Ready wait on resume. On enable exit 1/3, disable and re-enable with --recreate once.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
.github/workflows/on-pr-dory-smoke.yaml— spike / non-required smoke forhops local --backend doryon public GHA macOS.Install contract (not brew cask / release):
patrickleet/dory@feat/hops-local-integrationxcodebuildwith deterministic-derivedDataPathscripts/doryonPATHDory.appand wait for~/.dory/engine.sockbefore hops startIf engine boots: kind-parity smoke with
--backend doryandkubectl --context dory(dual registry names, stop/start resume, destroy + teardown).If public GHA cannot boot the engine: job stays
workflow_dispatch/ non-required — no forever-red required check. Spike outcome should be recorded on [[tasks/hops-cli-dory-macos-smoke]].macos-15(arm-oriented native engine path; nested virt may still fail)Implements [[tasks/hops-cli-dory-macos-smoke]] under parent [[tasks/hops-cli-macos-backend-smoke]].
Stacked on PR #70 (
feat/cluster-backend-abstraction).Test plan
workflow_dispatchonly until green public-GHA engine boot