refactor: make Session identity claims gateway-agnostic#126
Merged
Conversation
Hasura was only an example query layer, but convenience helpers and docs treated x-hasura-* as the protocol. Use neutral x-user-id/x-role keys, document Session as an opaque claim map, and keep gateway-specific names readable via Session::get.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (12)
📝 WalkthroughWalkthroughThe PR replaces Hasura-specific session identity names with ChangesMicrosvc session identity conventions
Estimated code review effort: 2 (Simple) | ~15 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
x-hasura-user-id/x-hasura-role) as the framework protocol forSessionx-user-id/x-role(USER_ID_KEY/ROLE_KEY) forSession::user_id()andSession::role()Session::get(...)Breaking change
Session::user_id()/Session::role()now readx-user-id/x-roleinstead ofx-hasura-user-id/x-hasura-role. Deployments that inject Hasura-native headers should either map claims at the edge or read them withsession.get("x-hasura-user-id").Test plan
cargo test -p distributed --features 'http,grpc' --lib sessioncargo test -p distributed --features 'http,grpc' --test microsvc(32 passed)Summary by CodeRabbit
New Features
x-user-idandx-roleconventions.Documentation
Tests