Allow colons in CODEOWNERS patterns#52
Open
laserlemon wants to merge 1 commit into
Open
Conversation
Treat colons as literal pattern characters and cover parsing and matching with a real-world rule. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 47810418-339a-4a4b-ad02-d060059420ce
laserlemon
force-pushed
the
laserlemon-allow-colon-patterns
branch
from
b9eabab to
dfe70d2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey Harry ol' buddy ol' pal! 💛
Summary
:as a literal CODEOWNERS pattern characterProblem
isPatternCharomitted colons, causing otherwise valid CODEOWNERS patterns to fail parsing with an unexpected-character error. The matcher already treats colons literally, so adding:to the parser whitelist is sufficient.Why
GitHub's CODEOWNERS validator API allows directory/file paths containing
:characters, but this library does not.Validation
go test ./...go vet ./...go build ./cmd/codeowners