docs: clarify glob() exclude resolves like pattern - #98
Merged
Conversation
heph PR #399 (97c5f48) fixed glob() so exclude entries resolve package-relative (or workspace-root-relative under abs=True) just like pattern, instead of being passed through raw. Document the resolved behavior in the buildfile guide and its heph-expert skill reference twin. Ref: hephbuild/heph#399
⚡ Cloudflare Pages preview
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hephbuild/hephPR #399 (commit97c5f48) fixed a bug in theglob()BUILD-file builtin:excludeentries were previously passed through raw and matched against workspace-root-relative paths, so a package-relativeexclude = ["vendor/**"]written inside//pkgsilently matched nothing. It's now resolved exactly likepattern— package-relative by default, workspace-root-relative underabs = True.This is a narrow breaking change to the BUILD-file Starlark API (per the heph PR's compatibility note: a workspace-rooted exclude written as a workaround now needs
abs = True), so it's worth documenting explicitly rather than leaving it implied by the general path-resolution paragraph.website/docs/plugins/buildfile.md(the "Authoring BUILD files" section).heph-expertClaude Code plugin's skill reference (plugins/heph-expert/skills/heph/references/authoring.md), per the reference-drift rule in this repo'sCLAUDE.md.Test plan
build/lintpass in CI.🤖 Generated with Claude Code
Generated by Claude Code