Fix CI release artifacts path and pin hightide to 0.15.0 - #16
Merged
Conversation
The release-artifacts collection step referenced the old `privacy` module path (`keycloak-extensions/privacy/target/helpwave-privacy-*.jar`), which broke after the module was renamed to `policy-acceptance`. Point it at `helpwave-policy-acceptance-*.jar` so the release job's `cp` succeeds. Also bump `@helpwave/hightide` to the latest release (0.15.0) and pin it exactly (drop the caret) so builds are reproducible. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ESgkc4jbJMUZf8SvMA4Uo3
The realm banner bar renders in normal document flow (sticky) as a sibling of the min-h-screen content area. Stacking a ~32px banner on top of a full 100vh content block made the document taller than the viewport, so pages like login scrolled even on tall screens. Wrap the banner and content in a single min-h-screen flex column and let the content fill the remaining space with flex-1, so banner + content share the viewport height instead of summing to 100vh + banner. Verified in-browser: document scrollHeight now equals the viewport height (was viewport + 32px) for team, admin, other and customer realms. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ESgkc4jbJMUZf8SvMA4Uo3
Tailwind v4 is processed by the @tailwindcss/vite plugin, which only prefixes the utilities it generates. Add an autoprefixer PostCSS pass so the full CSS bundle (including @helpwave/hightide styles) gets vendor prefixes, driven by a shared browserslist target list mirroring helpwave/tasks. - add `browserslist` field to package.json - add autoprefixer + postcss as devDependencies - add postcss.config.js running autoprefixer Verified against the built theme: -webkit-box-orient (0 -> 142) and -webkit-sticky (4 -> 8) prefixes now appear across the whole bundle. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ESgkc4jbJMUZf8SvMA4Uo3
Applies semver-compatible security updates for all 12 reported advisories (babel, ajv, brace-expansion, esbuild, flatted, js-yaml, minimatch, picomatch, rollup, storybook, vite, ws). All fixes stay within the existing version ranges in package.json, so no direct dependency majors change. `npm audit` now reports 0 vulnerabilities and the project still builds, lints, typechecks and runs. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01ESgkc4jbJMUZf8SvMA4Uo3
Deploying id-helpwave-de with
|
| Latest commit: |
b89200b
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://fd2262ce.id-helpwave-de.pages.dev |
| Branch Preview URL: | https://claude-ci-hightides-pinning.id-helpwave-de.pages.dev |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The release-artifacts collection step referenced the old
privacymodule path (keycloak-extensions/privacy/target/helpwave-privacy-*.jar), which broke after the module was renamed topolicy-acceptance. Point it athelpwave-policy-acceptance-*.jarso the release job'scpsucceeds.Also bump
@helpwave/hightideto the latest release (0.15.0) and pin it exactly (drop the caret) so builds are reproducible.Claude-Session: https://claude.ai/code/session_01ESgkc4jbJMUZf8SvMA4Uo3