✨ feat(mq-dap): add conditional/hit-count breakpoints, logpoints, and watch expressions#2010
Merged
harehare merged 5 commits intoJul 17, 2026
Merged
Conversation
… watch expressions Extends the DAP breakpoint model with condition, hit_condition, and log_message support, evaluated against the live scope at the breakpoint location. Logpoints report via a new output event instead of stopping. Also implements the previously-unhandled SetExpression request (used for inline watch editing) and advertises the corresponding DAP capabilities.
…ession Replace the hand-rolled ">= N"/"== N" prefix parser with the same eval_debug_expr path already used for condition and log_message, binding hit_count in scope. A bare number is still shorthand for "hit_count >= N", but any other string is now a full mq expression that can also reference other in-scope variables, e.g. "hit_count >= 2 && x == 4".
…nterpolation
Replace interpolate_log_message's hand-rolled {expr} scanner with mq's
own ${expr} interpolation syntax (lexer::parse_interpolation_segments),
reusing the same escape rules as s"..." literals. Also adds support for
${self} (current pipeline value) and ${$VAR} (env vars) in log messages.
This is a breaking change to logpoint message syntax: {x} -> ${x}.
…feature It is only used by DAP logpoint message interpolation, so building without the debugger feature was emitting a dead_code warning.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the DAP breakpoint model with condition, hit_condition, and log_message support, evaluated against the live scope at the breakpoint location. Logpoints report via a new output event instead of stopping. Also implements the previously-unhandled SetExpression request (used for inline watch editing) and advertises the corresponding DAP capabilities.
Type of Change
Checklist
cargo fmtandcargo clippyand addressed any warningsjust test-alland all tests pass/docs, crateREADME.md) if neededAdditional Context