-
Notifications
You must be signed in to change notification settings - Fork 3
V2.0 #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
halaei
wants to merge
11
commits into
halaei:master
Choose a base branch
from
Drazail:v2.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
V2.0 #2
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
6508cf8
Added Migration Plan
Drazail 1044d0b
Laravel 10-13 support, full test suite, and CI matrix. Preserves the …
Drazail 6841cba
Laravel 13 migration audit
Drazail 2fb42d3
Removed Migration Plan
Drazail 3f73ccd
added v2.0 to github actions
Drazail d2fae7e
fixing CI
Drazail f2c36cc
fixed "test_run_returns_null_when_proc_open_fails"
Drazail 7c87220
- Removed duplicate test_run_returns_null_when_proc_open_fails (same …
Drazail 473b814
Merge pull request #1 from Drazail/LaravelSpike
Drazail 074c828
removed codeCoverageIgnore intended as coverage boosters for migratio…
Drazail 818f631
Merge pull request #3 from Drazail/LaravelSpike
Drazail File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| .git | ||
| .idea | ||
| .vscode | ||
| vendor | ||
| build | ||
| .phpunit.result.cache | ||
| node_modules | ||
| terminals |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,2 +1,3 @@ | ||
| /tests export-ignore | ||
| /snippets export-ignore | ||
| *.sh text eol=lf |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,183 @@ | ||
| name: Tests | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - main | ||
| - master | ||
| - v2.0 | ||
| pull_request: | ||
|
|
||
| jobs: | ||
| matrix: | ||
| name: Laravel ${{ matrix.laravel }} / PHP ${{ matrix.php }} | ||
| runs-on: ubuntu-latest | ||
| strategy: | ||
| fail-fast: false | ||
| matrix: | ||
| include: | ||
| - laravel: '10' | ||
| php: '8.1' | ||
| testbench: '^8.0' | ||
| - laravel: '11' | ||
| php: '8.2' | ||
| testbench: '^9.0' | ||
| - laravel: '12' | ||
| php: '8.2' | ||
| testbench: '^10.0' | ||
| - laravel: '13' | ||
| php: '8.3' | ||
| testbench: '^11.0' | ||
|
|
||
| services: | ||
| redis: | ||
| image: redis:7-alpine | ||
| ports: | ||
| - 6379:6379 | ||
| mysql: | ||
| image: mysql:8.0 | ||
| env: | ||
| MYSQL_DATABASE: helpers_test | ||
| MYSQL_USER: helpers | ||
| MYSQL_PASSWORD: secret | ||
| MYSQL_ROOT_PASSWORD: root | ||
| ports: | ||
| - 3306:3306 | ||
| options: >- | ||
| --health-cmd="mysqladmin ping -h 127.0.0.1 -uhelpers -psecret" | ||
| --health-interval=10s | ||
| --health-timeout=5s | ||
| --health-retries=10 | ||
|
|
||
| env: | ||
| REDIS_HOST: 127.0.0.1 | ||
| REDIS_PORT: 6379 | ||
| DB_CONNECTION: mysql | ||
| DB_HOST: 127.0.0.1 | ||
| DB_PORT: 3306 | ||
| DB_DATABASE: helpers_test | ||
| DB_USERNAME: helpers | ||
| DB_PASSWORD: secret | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup PHP | ||
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: ${{ matrix.php }} | ||
| extensions: dom, json, mbstring, pcntl, pdo_mysql, pdo_sqlite, redis | ||
| coverage: none | ||
|
|
||
| - name: Get Composer cache directory | ||
| id: composer-cache | ||
| run: echo "dir=$(composer config cache-files-dir)" >> "$GITHUB_OUTPUT" | ||
|
|
||
| - name: Cache Composer dependencies | ||
| uses: actions/cache@v4 | ||
| with: | ||
| path: ${{ steps.composer-cache.outputs.dir }} | ||
| key: composer-${{ matrix.laravel }}-${{ hashFiles('composer.json', 'composer.lock') }} | ||
| restore-keys: composer-${{ matrix.laravel }}- | ||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| composer install --no-interaction --prefer-dist | ||
| composer require --dev "orchestra/testbench:${{ matrix.testbench }}" --no-interaction --no-update | ||
| composer update orchestra/testbench --with-all-dependencies --no-interaction --prefer-dist | ||
|
|
||
| - name: Verify Laravel version | ||
| run: | | ||
| php -r " | ||
| require 'vendor/autoload.php'; | ||
| \$app = require 'vendor/orchestra/testbench-core/laravel/bootstrap/app.php'; | ||
| \$app->make('Illuminate\Contracts\Console\Kernel')->bootstrap(); | ||
| echo \$app->version(); | ||
| " | grep -E '^${{ matrix.laravel }}\.' | ||
|
|
||
| - name: Run full behavioral suite | ||
| run: vendor/bin/phpunit -c phpunit.ci.xml --testsuite HalaeiHelpers,Characterization | ||
|
|
||
| - name: Public API contract | ||
| run: vendor/bin/phpunit -c phpunit.ci.xml --testsuite Contract | ||
|
|
||
| - name: Comprehensive validation | ||
| run: vendor/bin/phpunit -c phpunit.ci.xml --testsuite Validation | ||
|
|
||
| coverage: | ||
| name: Coverage (min 95% gate) | ||
| runs-on: ubuntu-latest | ||
|
|
||
| services: | ||
| redis: | ||
| image: redis:7-alpine | ||
| ports: | ||
| - 6379:6379 | ||
| mysql: | ||
| image: mysql:8.0 | ||
| env: | ||
| MYSQL_DATABASE: helpers_test | ||
| MYSQL_USER: helpers | ||
| MYSQL_PASSWORD: secret | ||
| MYSQL_ROOT_PASSWORD: root | ||
| ports: | ||
| - 3306:3306 | ||
| options: >- | ||
| --health-cmd="mysqladmin ping -h 127.0.0.1 -uhelpers -psecret" | ||
| --health-interval=10s | ||
| --health-timeout=5s | ||
| --health-retries=10 | ||
|
|
||
| env: | ||
| REDIS_HOST: 127.0.0.1 | ||
| REDIS_PORT: 6379 | ||
| DB_CONNECTION: mysql | ||
| DB_HOST: 127.0.0.1 | ||
| DB_PORT: 3306 | ||
| DB_DATABASE: helpers_test | ||
| DB_USERNAME: helpers | ||
| DB_PASSWORD: secret | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Setup PHP | ||
| uses: shivammathur/setup-php@v2 | ||
| with: | ||
| php-version: '8.3' | ||
| extensions: dom, json, mbstring, pcntl, pdo_mysql, pdo_sqlite, redis | ||
| coverage: pcov | ||
|
|
||
| - name: Install dependencies | ||
| run: | | ||
| composer install --no-interaction --prefer-dist | ||
| composer require --dev "orchestra/testbench:^11.0" --no-interaction --no-update | ||
| composer update orchestra/testbench --with-all-dependencies --no-interaction --prefer-dist | ||
|
|
||
| - name: Wait for MySQL | ||
| run: | | ||
| for i in $(seq 1 30); do | ||
| if php -r " | ||
| try { | ||
| new PDO( | ||
| 'mysql:host=127.0.0.1;port=3306;dbname=helpers_test', | ||
| 'helpers', | ||
| 'secret' | ||
| ); | ||
| exit(0); | ||
| } catch (Throwable \$e) { | ||
| exit(1); | ||
| } | ||
| "; then | ||
| echo "MySQL is ready." | ||
| exit 0 | ||
| fi | ||
| sleep 2 | ||
| done | ||
| echo "MySQL did not become ready in time." | ||
| exit 1 | ||
|
|
||
| - name: Coverage gate | ||
| run: bash scripts/check-coverage.sh |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| .idea | ||
| /vendor | ||
| /.phpunit.result.cache | ||
| composer.lock | ||
| /build | ||
| composer.lock |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are Docker changes only for test and migration from travis to github?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes