fix(oauth): make oauth app edit ui perm-consistent - #309
Open
matmanna wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a one line change which hides the redirect uri box in the 'edit app' menu for invited collaborators.
i was banging my head against my computer for a while trying to figure out why certain oauth apps allowed me to set the redirect url but finally realized that collaborators' ability to modify the field was removed in commit f6d90d4.
this pr just makes the frontend ui consistent with the new gating behavior as well as the already-conditional visibility of the 'rotate secret' button