chore(loader): RN hcaptcha loader integration#115
Open
damian-rodriguez-imi wants to merge 26 commits into
Open
chore(loader): RN hcaptcha loader integration#115damian-rodriguez-imi wants to merge 26 commits into
damian-rodriguez-imi wants to merge 26 commits into
Conversation
damian-rodriguez-imi
force-pushed
the
chore/add-hcaptcha-loader
branch
from
July 14, 2026 21:19
8bc107f to
3097c91
Compare
damian-rodriguez-imi
changed the title
damian-rodriguez-imi
marked this pull request as ready for review
July 15, 2026 20:10
damian-rodriguez-imi
marked this pull request as draft
July 15, 2026 20:12
damian-rodriguez-imi
marked this pull request as ready for review
July 15, 2026 20:19
damian-rodriguez-imi
force-pushed
the
chore/add-hcaptcha-loader
branch
from
July 15, 2026 20:23
8408df6 to
85c942b
Compare
damian-rodriguez-imi
marked this pull request as draft
July 15, 2026 20:23
damian-rodriguez-imi
marked this pull request as ready for review
July 15, 2026 20:24
damian-rodriguez-imi
marked this pull request as draft
July 15, 2026 20:32
damian-rodriguez-imi
marked this pull request as ready for review
July 15, 2026 20:32
damian-rodriguez-imi
marked this pull request as draft
July 15, 2026 20:36
damian-rodriguez-imi
marked this pull request as ready for review
July 15, 2026 20:48
brdlyptrs
reviewed
Jul 15, 2026
| return url; | ||
| }; | ||
|
|
||
| const buildHcaptchaLoaderConfig = ({ |
There was a problem hiding this comment.
Couldn't this just be an object than a function returning an object? I see the reason below, can you make this an actual function rather than a short hand const function to create a more declarative and understandable approach?
brdlyptrs
reviewed
Jul 15, 2026
brdlyptrs
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Loads
api.jsthrough@hcaptcha/loaderinside the React Native WebView, adding automatic retries, duplicate-load protection, and internal failure reporting while preserving the existing public SDK API.Notes
tests.yaml: pins iOS jobs to macOS 15 becausemacos-latestlacked the Xcode 16.4 installation and iOS 18.5 simulator explicitly used by CI.@react-native/jest-preset, so the generated app installs the matching version; unused@babel/preset-envwas removed because its Babel 8 peer requirement conflicted with RN's Babel 7.ConfirmHcaptchadefault so omission keeps the API default, while explicittrue/falseis preserved.