excluding html from error description, using error header for logging#16331
Open
mgosz-guardian wants to merge 4 commits into
Open
excluding html from error description, using error header for logging#16331mgosz-guardian wants to merge 4 commits into
mgosz-guardian wants to merge 4 commits into
Conversation
mgosz-guardian
added
the
maintenance
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
This change improves newsletter signup failure tracking in both signup flows. It uses a shared helper to extract structured failure details, prefers an Email-Signup-Error-Code response header when present, and otherwise falls back to a short error description capped at 60 characters.
Why?
The logger was consistently returning HTML as the error description because the failure responses were coming back as HTML. This is something I am currently investigating.