Skip to content

test: verify integration workflow Node.js fix#561

Open
ruromero wants to merge 4 commits into
guacsec:mainfrom
ruromero:test/integration-node-fix
Open

test: verify integration workflow Node.js fix#561
ruromero wants to merge 4 commits into
guacsec:mainfrom
ruromero:test/integration-node-fix

Conversation

@ruromero

@ruromero ruromero commented Jun 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

Temporary PR to verify that the Node.js setup fix in trustification/exhort-integration-tests#37 resolves the Windows CI failures.

Points the shared workflow call to ruromero/exhort-integration-tests@fix/update-node-setup-actions instead of @main.

Do not merge — this will be closed after verification. The real fix is in trustification/exhort-integration-tests#37.

Test plan

  • Windows integration tests pass
  • Linux and macOS integration tests still pass

🤖 Generated with Claude Code

Summary by Sourcery

CI:

  • Point the integration workflow to the exhort-integration-tests workflow in the ruromero fork at the fix/update-node-setup-actions ref instead of main for CI runs.

@sourcery-ai

sourcery-ai Bot commented Jun 17, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Temporarily repoints the integration GitHub Actions workflow to use a fork/branch of the shared exhort-integration-tests workflow that contains a Node.js setup fix, in order to validate Windows CI behavior.

File-Level Changes

Change Details Files
Update the integration workflow to consume a forked shared workflow branch with Node.js setup fixes instead of the main branch of the original repository.
  • Change the reusable workflow reference in the integration job from the trustification/exhort-integration-tests repository to the ruromero/exhort-integration-tests fork
  • Pin the reusable workflow to the fix/update-node-setup-actions branch rather than main to pick up Node.js setup changes for testing
.github/workflows/integration.yml

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ruromero ruromero added the hold Something needs to block this issue from merging label Jun 17, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Temporary change to test the Node.js setup fix from
trustification/exhort-integration-tests#37.

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@ruromero ruromero force-pushed the test/integration-node-fix branch from 2b6b83d to 07bae8c Compare June 17, 2026 09:58
@codecov-commenter

codecov-commenter commented Jun 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.75%. Comparing base (bdb4511) to head (29a81aa).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #561   +/-   ##
=======================================
  Coverage   90.75%   90.75%           
=======================================
  Files          36       36           
  Lines        7766     7766           
  Branches     1353     1353           
=======================================
  Hits         7048     7048           
  Misses        718      718           
Flag Coverage Δ
unit-tests 90.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hold Something needs to block this issue from merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants