fix(desktop): make guided setup reliable for fresh installations - #106
Merged
Conversation
tulayha
marked this pull request as ready for review
August 6, 2026 13:55
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This requires no repository rebuild, data migration, or new user configuration. Existing active runtimes remain unchanged unless the replacement passes validation.
Validation
npm --prefix desktop run check— TypeScript typecheck, ESLint, 38 Vitest component/adapter tests, and production frontend buildrustup run 1.97.1 cargo test --locked --manifest-path desktop/src-tauri/Cargo.toml— 79 Rust unit/process-contract tests with the candidate wheel embedded by the build scriptcargo fmt --manifest-path desktop/src-tauri/Cargo.toml -- --checkuv run --no-sync ruff check .uv run --no-sync python -m pytest tests/test_cli.py tests/test_capabilities.py -q— 52 targeted CLI and capability testsuv run --no-sync python -m unittest discover -s tests -q— 606 repository CI-style tests, 4 skippedvidxp-0.4.0b3wheel installs locally with--no-deps, then resolves thesceneextra from production PyPI in auv pip install --dry-rungit diff --checkThe complete 674-test pytest invocation did not finish within the five-minute local Windows command cap and reported no failing test before termination; the repository's CI-style unittest gate completed successfully. No macOS installer was built or manually exercised on this Windows host.