Merge inline fragments whose type condition is the enclosing type - #572
Open
antonshevchenko wants to merge 1 commit into
Open
Merge inline fragments whose type condition is the enclosing type#572antonshevchenko wants to merge 1 commit into
antonshevchenko wants to merge 1 commit into
Conversation
A type condition equal to the enclosing type is a no-op per the spec, but the codegen discarded the fragment's selections: when the fragment is the only selection the result is an empty enum, and when the parent selects anything else the fields silently vanish. Co-authored-by: Cursor <cursoragent@cursor.com>
antonshevchenko
marked this pull request as ready for review
August 5, 2026 00:33
tomhoule
approved these changes
Aug 7, 2026
tomhoule
left a comment
Member
There was a problem hiding this comment.
Awesome! Thank you for the contribution.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A type condition equal to the enclosing type is a no-op per the spec, but the codegen discards the fragment's selections.
When the fragment is the only selection, the result is an empty enum that can never deserialize:
generates
pub enum ExampleThing {}, and every response fails withunknown variant `Thing`, there are no variants.When the parent selects anything else, it compiles and the fields silently vanish:
Fixes #394, #416.