Document QR v2 conditioning hardening#163
Draft
msaroufim wants to merge 1 commit into
Draft
Conversation
40ca746 to
b208d15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tests:is a local smoke path and that competition-enforced numerical robustness belongs inbenchmarks:.512 x 512rowscaleandnearcollinearbenchmark cases so shape-only precision routing is checked in leaderboard mode, not only local test mode.Why
QR v2 allows implementations to choose internal precision strategies, but the benchmark should not over-reward routing based only on public shape IDs. The important guardrail has to live in
benchmarks:because leaderboard mode validates benchmark outputs and ranks those cases.tests:can still help local iteration, but it should not be treated as the enforcement mechanism.Validation
ruby -e 'require "yaml"; doc = YAML.load_file("problems/linalg/qr_v2/task.yml"); puts "tests=#{doc["tests"].length} benchmarks=#{doc["benchmarks"].length}"; raise "missing README" unless File.exist?("problems/linalg/qr_v2/README.md")'uv run python - <<'PY' ... checked inline task specs and QR case names ... PYgit diff --checkNot run: QR numerical checker with
torch, because the local Python/uv environments available in this workspace do not havetorchinstalled.