Remove fragmentation profile#316
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Conversation
The fragmentation profile is not useful in the current form. The proxy allocation stacks are not correlated and are not the cause of external fragmentation. They are just random objects of a particular size class. We don't see that these profiles are used in practice. External fragmentation of more of a global tcmalloc property that depends on CFL span prioritization, etc. The information about external fragmentation is available in a more complete form in mallocz CFL info, and if necessary can be crossed with heapz for representative stacks. PiperOrigin-RevId: 941602092
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove fragmentation profile
The fragmentation profile is not useful in the current form.
The proxy allocation stacks are not correlated and are not the cause
of external fragmentation. They are just random objects of a particular
size class.
We don't see that these profiles are used in practice.
External fragmentation of more of a global tcmalloc property that depends
on CFL span prioritization, etc. The information about external fragmentation
is available in a more complete form in mallocz CFL info, and if necessary
can be crossed with heapz for representative stacks.