Revive same-span telemetry in CentralFreeList#311
Draft
copybara-service[bot] wants to merge 1 commit into
Draft
Conversation
This CL revives the telemetry reverted in cl/809203378, but optimizes it to only look for consecutive runs of the same span in the batch rather than fully sorting the pointers. This avoids the sorting cost while still providing a useful estimate for a potentially common-but-cheap to fix pattern. The logic is placed in a helper lambda in CentralFreeList::InsertRange to facilitate profiling and cost tracking. PiperOrigin-RevId: 941771463
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Revive same-span telemetry in CentralFreeList
This CL revives the telemetry reverted in cl/809203378, but optimizes
it to only look for consecutive runs of the same span in the batch
rather than fully sorting the pointers. This avoids the sorting cost
while still providing a useful estimate for a potentially common-but-cheap to
fix pattern.
The logic is placed in a helper lambda in CentralFreeList::InsertRange
to facilitate profiling and cost tracking.