pybind: Wire up S2Cell.get_cap_bound()#654
Open
Shaurya2k06 wants to merge 1 commit into
Open
Conversation
PR google#646 claimed to resolve the TODO in s2cell_bindings.cc by binding S2Cell.get_cap_bound() now that S2Cap is registered before S2Cell in the module initialization order, but the actual .def() call was never added; the TODO comment and missing binding remained. Bind S2Cell::GetCapBound and update the TODO to note that only get_rect_bound() is still deferred pending S2LatLngRect bindings. Signed-off-by: shaurya2k06 <shaurya2k06@gmail.com>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #646 claimed to resolve the TODO in
s2cell_bindings.ccby bindingS2Cell.get_cap_bound(), sinceS2Capis now registered beforeS2Cellin the module initialization order. However, the actual.def()call was never added, leaving both the TODO comment and the binding absent.This change adds the missing binding for
S2Cell::GetCapBound, following the same pattern used forS2Cap.cap_bound(). It also updates the TODO comment to reflect the current state: onlyget_rect_bound()remains deferred, pendingS2LatLngRectbindings.Testing
bazel test //python:s2cell_test //python:s2cap_testBoth test suites pass locally, including a new
test_get_cap_boundtest that verifies the returned cap contains the cell's center and all of its vertices.Fixes #650