aws: ensure role assumption is done after other options are parsed#3732
Merged
vangent merged 1 commit intoJun 16, 2026
Merged
Conversation
vangent
reviewed
Jun 16, 2026
Without this change, the map is iterated over in a random order, which will cause issues if another paramter (e.g. region) is provided and needed.
1bcb9bb to
c671099
Compare
Contributor
Author
|
Good thought, I agree -- @vangent ; updated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes an issue introduced with the new feature in #3716 . Without this change, the options map is iterated over in a random order, which will cause issues if another parameter (e.g. region) is provided and needed.
Current tests don't catch this, but this part of the PR:
does exercise the tests -- if that same check was added to the current code, the current tests will fail sporadically.