macOS: normalize SHM names and propagate blob creation failures#151
macOS: normalize SHM names and propagate blob creation failures#151jovemexausto wants to merge 4 commits into
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Signed-off-by: Marcus Figueiredo <figueiredo@protonmail.com>
Signed-off-by: Marcus Figueiredo <figueiredo@protonmail.com>
367ef17 to
273e368
Compare
|
Reopened after signing the CLA. I hope this fix is useful to the project; it was essential for my current research, and I’m happy to help with any follow-up. |
|
The companion patch in libkrun is here. Together they unblock the macOS gfxstream blob-mapping path. |
gurchetansingh
left a comment
There was a problem hiding this comment.
Can you add which MacOS builds configuration you're using (I assume) to the Gitlab CI/CD via modifying the actions?
| #else | ||
| mName = name; | ||
| #endif | ||
| } |
There was a problem hiding this comment.
I guess you can make this slash universal, even on linux. Also, cite the POSIX standard that requires a slash in a comment.
There was a problem hiding this comment.
Thanks! Made the shm_open() name normalization universal, not macOS-only, and added an inline POSIX.1-2017 citation.
cd830b4 to
193aaa4
Compare
|
Hi! I addressed both comments in this PR:
I should be candid here: I initially scoped this PR narrowly to a concrete bug fix, but that turned out to be incomplete because the change really only makes sense with a working macOS build path. I overlooked that at first. The complete macOS stack is already working in my companion branch, with a passing build here. If you'd prefer, I can fold that macOS host-build stack into this PR so the CI job reflects a fully green macOS path. |
193aaa4 to
be7de40
Compare
|
Yeah, it makes sense to add all of the MacOS build support patches, to ensure CI/CD coverage of the use case. Can you add them here? Also, make Thanks! |
| name: Gfxstream macOS Build | ||
|
|
||
| on: | ||
| pull_request: |
There was a problem hiding this comment.
Can you add this presubmit.yml instead of it's own file?
|
Thanks for the follow-up, @gurchetansingh! I'll take some time this weekend to go through and address all your points |
Summary
shm_open().stream_renderer_create_blob()instead of always reporting success.Why
These fixes make blob-backed GPU resources fail loudly and keep macOS SHM creation compatible with the expected POSIX naming rules.
Validation