CIPD: Add riscv64 string to detect native riscv64. - #78
Open
Xeonacid wants to merge 1 commit into
Open
Conversation
|
👋 Thanks for your contribution! Your PR has been imported to Gerrit. |
That's what platform.machine reports on Linux, causing failure to build on riscv64. Unclear whether we also need an emulated_x86-style fallback like arm64 has (detecting armv8 via platform.processor() when platform.machine() reports x86). What situations run x86 Python on arm64? And if platform.machine() is unreliable in that case, why not rely solely on platform.processor() instead?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That's what platform.machine reports on Linux, causing failure to build on riscv64.
Unclear whether we also need an emulated_x86-style fallback like arm64 has (detecting armv8 via platform.processor() when platform.machine() reports x86). What situations run x86 Python on arm64? And if platform.machine() is unreliable in that case, why not rely solely on platform.processor() instead?