Fix race condition in PeriodicAdvertisingSync state transition#951
Open
zxzxwu wants to merge 1 commit into
Open
Fix race condition in PeriodicAdvertisingSync state transition#951zxzxwu wants to merge 1 commit into
zxzxwu wants to merge 1 commit into
Conversation
In PeriodicAdvertisingSync.establish, the state was unconditionally set to PENDING after sending the create sync command. If the sync was established immediately (e.g. HCI_LE_PERIODIC_ADVERTISING_SYNC_ESTABLISHED_EVENT received before establish completed), the state transition to ESTABLISHED would be overwritten back to PENDING, causing timeouts in listeners waiting for establishment. Only set state to PENDING if it is still INIT. TAG=agy CONV=e61bef8b-ae31-48da-9bac-74f55d92568d
uier
approved these changes
Jul 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In PeriodicAdvertisingSync.establish, the state was unconditionally set to PENDING after sending the create sync command. If the sync was established immediately (e.g. HCI_LE_PERIODIC_ADVERTISING_SYNC_ESTABLISHED_EVENT received before establish completed), the state transition to ESTABLISHED would be overwritten back to PENDING, causing timeouts in listeners waiting for establishment.
Only set state to PENDING if it is still INIT.
TAG=agy
CONV=e61bef8b-ae31-48da-9bac-74f55d92568d