feat: support axis-specific padding component sub-tokens - #166
Open
zachshallbetter wants to merge 1 commit into
Open
feat: support axis-specific padding component sub-tokens#166zachshallbetter wants to merge 1 commit into
zachshallbetter wants to merge 1 commit into
Conversation
Implemented support for axis-specific padding properties (paddingX and paddingY) inside component token definitions (resolves Issue google-labs-code#160). * Background & Motivation: - By default, the linter and spec support a uniform 'padding' sub-token for components. However, asymmetric layouts (e.g. button rows or inputs with larger horizontal than vertical insets) are standard in production design systems. Adding 'paddingX' and 'paddingY' solves this gap natively. - This matches common framework models (Tailwind's px/py, SwiftUI, Flutter) and avoids nested layout complexity (such as the schemas discussed in Issue google-labs-code#17). - This aligns with the philosophy of PR google-labs-code#89 (avoiding CSS property bloat like paddingLeft/paddingTop) by introducing structural layout minimums rather than exhaustive box-model properties. - Sourced independently from PR google-labs-code#164 to prevent merge conflicts. * Changes: - Add 'paddingX' and 'paddingY' to component_sub_tokens list in spec-config.yaml. - Update the valid component properties list in README.md. - Regenerate docs/spec.md using the compiler script. * Test Coverage: - Add validation tests in broken-ref.test.ts to verify that components using paddingX and paddingY do not trigger unrecognized sub-token warnings.
This was referenced Aug 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implemented support for axis-specific padding properties (
paddingXandpaddingY) inside component token definitions (resolves Issue #160).Background & Motivation
By default, the linter and spec support a uniform
paddingsub-token for components. However, asymmetric layouts (e.g., text inputs with different vertical and horizontal offsets) are standard in production design systems. AddingpaddingXandpaddingYaddresses this capability gap natively.px/py, SwiftUI, Flutter) and avoids nested layout mess (such as the very helpful schema formats discussed in #Issue Feature: Add Support for Component Variations #17).paddingLeft/paddingTop) by introducing structural layout minimums rather than exhaustive box-model properties.Changes
paddingXandpaddingYto the recognizedcomponent_sub_tokensschema list inspec-config.yaml.broken-ref.test.tsverifying that component definitions containingpaddingXandpaddingYdo not emit unrecognized sub-token warnings.README.md.docs/spec.mdusing the spec compiler.