fix(lcm): assure latest tag matches retagged ones#2083
Conversation
📝 WalkthroughWalkthroughA single line is added to the retag workflow's loop that unconditionally executes a crane tag command applying the "latest" tag, running regardless of the DRY_RUN setting, whereas previously this action was skipped during dry-run mode. ChangesRetag Workflow Update
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In @.github/workflows/lcm-stable-retag.yaml:
- Line 79: The latest tag is currently applied only once after the image loop,
so only the last image gets tagged and it still runs during dry runs. Move the
`crane tag` for `latest` into the same per-image loop used in the retagging
logic, alongside the major tag handling, and guard it with the existing
`DRY_RUN` branch in the workflow.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 3658a3c8-60cf-4b62-bb19-f363045e032c
📒 Files selected for processing (1)
.github/workflows/lcm-stable-retag.yaml
bfb6949 to
4b1ce01
Compare
This PR adds assures
latestfor new retagged imgs and simplifies the logic a bitSummary by CodeRabbit
latesttag during the retagging process, even in dry-run mode.