Skip to content

fix(lcm): assure latest tag matches retagged ones#2083

Open
santos1709 wants to merge 1 commit into
masterfrom
lcm-reag-latest-fix
Open

fix(lcm): assure latest tag matches retagged ones#2083
santos1709 wants to merge 1 commit into
masterfrom
lcm-reag-latest-fix

Conversation

@santos1709

@santos1709 santos1709 commented Jul 1, 2026

Copy link
Copy Markdown
Contributor

This PR adds assures latest for new retagged imgs and simplifies the logic a bit

Summary by CodeRabbit

  • Bug Fixes
    • Image retagging now also updates the latest tag during the retagging process, even in dry-run mode.

@coderabbitai

coderabbitai Bot commented Jul 1, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

A single line is added to the retag workflow's loop that unconditionally executes a crane tag command applying the "latest" tag, running regardless of the DRY_RUN setting, whereas previously this action was skipped during dry-run mode.

Changes

Retag Workflow Update

Layer / File(s) Summary
Unconditional latest tag application
.github/workflows/lcm-stable-retag.yaml
Adds an unconditional crane tag "${src}" "latest" call within the retag loop, executing regardless of the DRY_RUN flag.

Estimated code review effort: 2 (Simple) | ~10 minutes

Poem

A hop, a skip, a tag applied,
No dry-run pause to step aside,
"Latest" now sticks, come rain or shine,
This bunny checks each retag line! 🐇🏷️

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly matches the change to ensure the latest tag is applied alongside retagged images.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In @.github/workflows/lcm-stable-retag.yaml:
- Line 79: The latest tag is currently applied only once after the image loop,
so only the last image gets tagged and it still runs during dry runs. Move the
`crane tag` for `latest` into the same per-image loop used in the retagging
logic, alongside the major tag handling, and guard it with the existing
`DRY_RUN` branch in the workflow.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 3658a3c8-60cf-4b62-bb19-f363045e032c

📥 Commits

Reviewing files that changed from the base of the PR and between 7ba732e and bfb6949.

📒 Files selected for processing (1)
  • .github/workflows/lcm-stable-retag.yaml

Comment thread .github/workflows/lcm-stable-retag.yaml Outdated
@santos1709 santos1709 force-pushed the lcm-reag-latest-fix branch from bfb6949 to 4b1ce01 Compare July 1, 2026 13:51

@zhabba zhabba left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 +1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants