Set the send timeout the way Winsock expects - #161
Open
DTW-Thalion wants to merge 1 commit into
Open
Conversation
Winsock takes SO_SNDTIMEO as a DWORD of milliseconds rather than a struct timeval, and its optval is const char* rather than const void*. Casting the timeval compiles and then sets the timeout from the wrong bytes, so the value is built per platform.
DTW-Thalion
marked this pull request as ready for review
August 14, 2026 02:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Winsock takes SO_SNDTIMEO as a DWORD of milliseconds rather than a struct timeval, and its optval is const char* rather than const void*.
The compiler reports only the pointer type, so the obvious repair is a cast. That compiles and then sets the timeout from the bytes of a struct timeval, which is not a millisecond count. The value is built per platform instead.
Found building on MSYS2 ucrt64 with clang 22.