Fix: register CFSocket and correct its address accessors - #154
Open
DTW-Thalion wants to merge 1 commit into
Open
Fix: register CFSocket and correct its address accessors#154DTW-Thalion wants to merge 1 commit into
DTW-Thalion wants to merge 1 commit into
Conversation
CFInitialize did not call CFSocketInitialize, so the socket type was never registered. CFSocketGetTypeID returned zero and every attempt to create a socket failed. Add the missing registration. CFSocketCopyAddress and CFSocketCopyPeerAddress passed an uninitialised length to getsockname and getpeername. Set it to the size of the address buffer, hold the result in a sockaddr_storage, and cache the address only when the call succeeds. CFSocketCopyPeerAddress also read and stored the local _address field rather than _peerAddress, so it returned the local address; it now uses the peer field, which leaves an unconnected socket with no peer address.
DTW-Thalion
force-pushed
the
fix-cfsocket-init-address
branch
from
July 24, 2026 15:22
e6caffc to
15a3a23
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CFInitialize did not call CFSocketInitialize, so the socket type was never registered. CFSocketGetTypeID returned zero and every attempt to create a socket failed, which left the whole class unusable. This adds the missing registration.
CFSocketCopyAddress and CFSocketCopyPeerAddress passed an uninitialised length to getsockname and getpeername. They now set it to the size of the address buffer, hold the result in a sockaddr_storage, and cache the address only when the call succeeds. CFSocketCopyPeerAddress also read and stored the local _address field rather than _peerAddress, so it returned the local address; it now uses the peer field, which leaves an unconnected socket with no peer address.
Tests/CFSocket/basic.m and peeraddr.m cover creation, the native handle, validity, socket flags, the context, binding to a loopback address and the peer address, against values taken from Apple CoreFoundation. Both fail before this change and pass after.