Fix: CFAttributedString SetAttributes replaces attributes when clearing others - #150
Open
DTW-Thalion wants to merge 1 commit into
Open
Conversation
This was referenced Jul 22, 2026
DTW-Thalion
force-pushed
the
fix-cfattributedstring-clear-attributes
branch
from
July 24, 2026 15:22
93c38e3 to
ee74cc1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CFAttributedStringSetAttributes with clearOtherAttributes set, when the range begins at an existing attribute boundary, went through ReplaceAttributesAtIndex. That function re-cached the existing attributes and ignored its replacement argument, so the old attributes were kept instead of being replaced by the new ones.
Pass the replacement dictionary to the cache.
The test set_clear.m sets an attribute over a run, then sets a different attribute over the same range with clearOtherAttributes true; it fails before this change (the first attribute survives) and passes after. Verified against Apple CoreFoundation.
Related
Part of the CFAttributedString series. #152 (substring, attribute removal and replacement) depends on this and on #151.