Fix: CFTree retains and releases its context info - #148
Open
DTW-Thalion wants to merge 1 commit into
Open
Conversation
DTW-Thalion
force-pushed
the
fix-cftree-context-lifecycle
branch
from
July 24, 2026 15:22
570839f to
7188a51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CFTreeCreate copied the context but never called its retain callback, and CFTreeFinalize passed the tree itself to the release callback instead of the context info. A tree created with a retaining context therefore released the wrong object on finalization, double-freeing the tree, and never retained or released its info.
CFTreeCreate now retains the info through the context retain callback, and CFTreeFinalize releases the info. This is the behaviour CFXMLTreeCreateWithNode relies on.
The test context.m fails before this change (it aborts when the tree is released) and passes after. Verified against Apple CoreFoundation.