CFRunLoop: mark a new observer valid - #140
Open
DTW-Thalion wants to merge 2 commits into
Open
Conversation
CFRunLoopObserverCreate never set the valid flag, so CFRunLoopObserverIsValid returned false for a newly created observer.
DTW-Thalion
force-pushed
the
fix/cfrunloop-observer-valid
branch
from
July 24, 2026 15:22
46bbcc2 to
706f282
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CFRunLoopObserverCreate initialised the observer's activities, order and callback but never set its valid flag, so CFRunLoopObserverIsValid returned false for a newly created observer (the timer and source creators set the flag).
Set the flag when the observer is created.
Tests/CFRunLoop/observer_valid.m checks that a new observer is valid and an invalidated one is not, verified against Apple CoreFoundation.