Fail daily AIC guardrail as workflow error and rename ET guardrail wiring to daily_ai_credits_*#38573
Closed
Copilot wants to merge 2 commits into
Closed
Fail daily AIC guardrail as workflow error and rename ET guardrail wiring to daily_ai_credits_*#38573Copilot wants to merge 2 commits into
daily_ai_credits_*#38573Copilot wants to merge 2 commits into
Conversation
Co-authored-by: dsyme <7204669+dsyme@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Improve user information for daily effective limit issues
Fail daily AIC guardrail as workflow error and rename ET guardrail wiring to Jun 11, 2026
daily_ai_credits_*
Collaborator
|
This guardrail failure needs to be propagated to the conclusion job that files an issue. If you want to fail a job, it should be the conclusion after filing the issues. Let's talk about this one. |
pelikhan
requested changes
Jun 11, 2026
| core.warning(`Daily workflow AIC guardrail exceeded for ${workflowName}: ${totalAIC}/${threshold}.`); | ||
| const exceededMessage = `Daily workflow AIC guardrail exceeded for ${workflowName}: ${totalAIC}/${threshold}. See ${DAILY_AIC_GUARDRAIL_DOCS_URL}`; | ||
| core.error(exceededMessage); | ||
| core.setFailed(exceededMessage); |
Collaborator
There was a problem hiding this comment.
This will skip the conclusion job that files the issue.
Collaborator
|
Carving a sub PR for renames so we split this change https://github.com/github/gh-aw/tasks/f1cc7421-a69e-4df3-afb1-e3e43ce8fa4f |
Collaborator
|
See #38611 |
Collaborator
Collaborator
|
Implemented. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The daily per-workflow AI Credits guardrail was signaling exceedance as a warning and allowing confusing artifact download warnings to dominate logs, which made guardrail trips easy to miss. This change promotes guardrail exceedance to an explicit workflow failure with actionable guidance and aligns generated/runtime naming with AI Credits terminology.
Guardrail exceedance is now a hard failure
check_daily_aic_workflow_guardrail.cjsnow emitscore.error(...)andcore.setFailed(...)when 24h AIC exceeds threshold.Suppress misleading artifact-not-found noise
Rename generated and runtime guardrail wiring
daily_effective_workflow_*outputs/conditions/env wiring withdaily_ai_credits_*across compiler output wiring, activation/main/conclusion conditions, failure-handler context keys, and golden fixtures.GH_AW_DAILY_EFFECTIVE_WORKFLOW_*toGH_AW_DAILY_AI_CREDITS_*.Failure-report templates and context keys updated
daily_ai_credits_*.