ref(analytics): Clarify SCM framework flow naming#120233
Merged
jaydgoss merged 1 commit intoJul 24, 2026
Merged
Conversation
github-actions
Bot
added
the
Scope: Frontend
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-attribution-payloads
branch
from
July 21, 2026 17:57
2704d0d to
c73a1a8
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-framework-flow-naming
branch
from
July 21, 2026 17:58
5f80949 to
398a35d
Compare
jaydgoss
marked this pull request as ready for review
July 21, 2026 18:07
bruno-garcia
approved these changes
Jul 22, 2026
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-attribution-payloads
branch
from
July 23, 2026 19:24
c73a1a8 to
f2ad681
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-framework-flow-naming
branch
from
July 23, 2026 19:24
398a35d to
e0df88f
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-attribution-payloads
branch
from
July 23, 2026 20:42
f2ad681 to
249d4a0
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-framework-flow-naming
branch
from
July 23, 2026 20:42
e0df88f to
626b426
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-attribution-payloads
branch
from
July 23, 2026 20:54
249d4a0 to
8f6b657
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-framework-flow-naming
branch
from
July 23, 2026 20:54
626b426 to
2f74a76
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-attribution-payloads
branch
from
July 23, 2026 21:09
8f6b657 to
d8324d5
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-framework-flow-naming
branch
from
July 23, 2026 21:09
2f74a76 to
0e08b2a
Compare
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-attribution-payloads
branch
from
July 24, 2026 01:53
d8324d5 to
5b14077
Compare
Base automatically changed from
jaygoss/scm-project-creation-attribution-payloads
to
master
July 24, 2026 02:09
Rename the FrameworkSuggestionModal prop from hasScmOnboarding to isScmFlow because the shared modal now serves both SCM onboarding and SCM-first project creation. Behavior is unchanged. Refs VDY-133
jaydgoss
force-pushed
the
jaygoss/scm-project-creation-framework-flow-naming
branch
from
July 24, 2026 02:09
0e08b2a to
18205b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TLDR
FrameworkSuggestionModalnow usesisScmFlowinstead ofhasScmOnboarding, matching its use by both SCM onboarding and SCM-first project creation. Analytics routing is unchanged;analyticsFlowcontinues to distinguish the two SCM contexts.Refs VDY-133