chore(ureq): Record envelope losses in the Ureq transport#1178
Open
szokeasaurusrex wants to merge 1 commit into
Open
chore(ureq): Record envelope losses in the Ureq transport#1178szokeasaurusrex wants to merge 1 commit into
szokeasaurusrex wants to merge 1 commit into
Conversation
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
d0fb9ec to
bd8072f
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/ureq-losses
branch
2 times, most recently
from
909c0a7 to
4a14916
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
bd8072f to
28f9398
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/ureq-losses
branch
from
4a14916 to
1d62e22
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
28f9398 to
1d70a92
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/ureq-losses
branch
from
1d62e22 to
dec4c12
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
1d70a92 to
d566a6d
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/ureq-losses
branch
from
dec4c12 to
42903b4
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
2 times, most recently
from
0d1f9c7 to
78d07ac
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/ureq-losses
branch
from
42903b4 to
e7bcd1e
Compare
Record lost envelopes in the `ureq` transport after the transport thread accepts them for sending. Ureq request failures are recorded as `network_error`; non-`429` HTTP `4xx`/`5xx` responses are recorded as `send_error`. Keep existing rate-limit handling for `429` responses and the existing payload-too-large debug message for `413` responses. Closes [#1153](#1153) Closes [RUST-228](https://linear.app/getsentry/issue/RUST-228)
szokeasaurusrex
force-pushed
the
szokeasaurusrex/ureq-losses
branch
from
e7bcd1e to
844ce7b
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/curl-losses
branch
from
78d07ac to
c5ba012
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Record lost envelopes in the
ureqtransport after the transport thread accepts them for sending. Ureq request failures are recorded asnetwork_error; non-429HTTP4xx/5xxresponses are recorded assend_error.Keep existing rate-limit handling for
429responses and the existing payload-too-large debug message for413responses.Closes #1153
Closes RUST-228