ref(envelope): Reuse item types in serialization#1166
Open
szokeasaurusrex wants to merge 1 commit into
Open
Conversation
szokeasaurusrex
force-pushed
the
szokeasaurusrex/envelope-type-improvement
branch
from
4130136 to
263bcb0
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transport-options
branch
from
f9b553c to
07f3fa0
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/envelope-type-improvement
branch
2 times, most recently
from
5e3017a to
8034ba5
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transport-options
branch
from
07f3fa0 to
0679651
Compare
This refactor should force us to make sure we add EnvelopeItemTypes corresponding to new EnvelopeItems: basically this sort of error should become impossible: #1144 (comment).
szokeasaurusrex
force-pushed
the
szokeasaurusrex/envelope-type-improvement
branch
from
8034ba5 to
ea171be
Compare
szokeasaurusrex
force-pushed
the
szokeasaurusrex/transport-options
branch
from
0679651 to
69b06e3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactor should force us to make sure we add EnvelopeItemTypes corresponding to new EnvelopeItems: basically this sort of error should become impossible: #1144 (comment).