Skip to content

feat(falcon): Set name and source on request span when streaming#6562

Open
alexander-alderman-webb wants to merge 7 commits into
webb/falcon/span-firstfrom
webb/falcon/txn-name
Open

feat(falcon): Set name and source on request span when streaming#6562
alexander-alderman-webb wants to merge 7 commits into
webb/falcon/span-firstfrom
webb/falcon/txn-name

Conversation

@alexander-alderman-webb

@alexander-alderman-webb alexander-alderman-webb commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Description

Call Scope.set_transaction_name() on the current scope in process_resource() to change the name and source of the segment span when span streaming is enabled.

Issues

Closes #6019

Reminders

@alexander-alderman-webb alexander-alderman-webb marked this pull request as ready for review June 12, 2026 08:18
@alexander-alderman-webb alexander-alderman-webb requested a review from a team as a code owner June 12, 2026 08:18

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0c17904. Configure here.

Comment thread sentry_sdk/integrations/falcon.py Outdated
@github-actions

github-actions Bot commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

89644 passed | ⏭️ 6019 skipped | Total: 95663 | Pass Rate: 93.71% | Execution Time: 301m 35s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +199
Passed Tests 📈 +193
Failed Tests
Skipped Tests 📈 +6

All tests are passing successfully.

✅ Patch coverage is 87.50%. Project has 2396 uncovered lines.
✅ Project coverage is 89.79%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/falcon.py 87.50% ⚠️ 1 Missing and 1 partials
Coverage diff
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.75%    89.79%    +0.04%
==========================================
  Files          192       192         —
  Lines        23486     23465       -21
  Branches      8066      8062        -4
==========================================
+ Hits         21079     21069       -10
- Misses        2407      2396       -11
- Partials      1329      1330        +1

Generated by Codecov Action

Comment thread sentry_sdk/integrations/falcon.py

@ericapisani ericapisani left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question, but otherwise LGTM

"path": req.path,
}
name = name_for_style[integration.transaction_style]
source = SOURCE_FOR_STYLE[integration.transaction_style]

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If, based on my understanding of the pull request description, process_resource is intended t be run when span streaming is enabled, should this instead be using the SOURCE_FOR_STYLE from sentry_sdk.traces instead of sentry_sdk.tracing?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants