-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
docs(cloudflare): Recommend span streaming for MCP #19057
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
betegon
wants to merge
2
commits into
master
Choose a base branch
from
docs/cloudflare-mcp-span-streaming
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 15 additions & 0 deletions
15
platform-includes/mcp-monitoring/setup/javascript.azure-functions.mdx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| Import Sentry from `@sentry/node`, then wrap the MCP server instance before connecting it to a transport: | ||
|
|
||
| ```javascript {filename:mcp-server.js} | ||
| import * as Sentry from "@sentry/node"; | ||
| import { McpServer } from "@modelcontextprotocol/server"; | ||
|
|
||
| const server = Sentry.wrapMcpServerWithSentry( | ||
| new McpServer({ | ||
| name: "my-mcp-server", | ||
| version: "1.0.0", | ||
| }) | ||
| ); | ||
| ``` | ||
|
|
||
| Register tools, prompts, and resources on `server` as usual. The wrapper returns the same server instance. |
32 changes: 32 additions & 0 deletions
32
platform-includes/mcp-monitoring/setup/javascript.hono.mdx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| Hono uses a runtime-specific Sentry entrypoint. Import Sentry from the entrypoint that matches your deployment: | ||
|
|
||
| ```javascript {tabTitle:Cloudflare Workers} {filename:mcp-server.js} | ||
| import * as Sentry from "@sentry/hono/cloudflare"; | ||
| ``` | ||
|
|
||
| ```javascript {tabTitle:Node.js} {filename:mcp-server.js} | ||
| import * as Sentry from "@sentry/hono/node"; | ||
| ``` | ||
|
|
||
| ```javascript {tabTitle:Bun} {filename:mcp-server.js} | ||
| import * as Sentry from "@sentry/hono/bun"; | ||
| ``` | ||
|
|
||
| ```javascript {tabTitle:Deno} {filename:mcp-server.js} | ||
| import * as Sentry from "@sentry/hono/deno"; | ||
| ``` | ||
|
|
||
| Then wrap the MCP server instance before connecting it to a transport: | ||
|
|
||
| ```javascript {filename:mcp-server.js} | ||
| import { McpServer } from "@modelcontextprotocol/server"; | ||
|
|
||
| const server = Sentry.wrapMcpServerWithSentry( | ||
| new McpServer({ | ||
| name: "my-mcp-server", | ||
| version: "1.0.0", | ||
| }) | ||
| ); | ||
| ``` | ||
|
|
||
| Register tools, prompts, and resources on `server` as usual. The wrapper returns the same server instance. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| Import Sentry from your framework's SDK package, then wrap the MCP server instance before connecting it to a transport: | ||
|
|
||
| ```javascript {filename:mcp-server.js} | ||
| import * as Sentry from "___SDK_PACKAGE___"; | ||
| import { McpServer } from "@modelcontextprotocol/server"; | ||
|
|
||
| const server = Sentry.wrapMcpServerWithSentry( | ||
| new McpServer({ | ||
| name: "my-mcp-server", | ||
| version: "1.0.0", | ||
| }) | ||
| ); | ||
| ``` | ||
|
|
||
| Register tools, prompts, and resources on `server` as usual. The wrapper returns the same server instance. |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is it common for us to have this type of recommendation listed in all JS frameworks? I would assume we'd have it in the browser one perhaps? Or maybe I'm misunderstanding what we're trying to say here.
If I'm on a selected SDK, and we support it, this is a confusing thing to be reading. I'm also assuming I can use these attributes even in supported SDKs?
@betegon , can you help clarify and I can make a suggestion for rewording?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm great question. i'm not sure if this is common, i'll look it up. there's a bunch of official (from anthropic) MCP SDKs. we support JS and Python for now, there's GO, PHP and some more.
>if I'm on a selected SDK, and we support it, this is a confusing thing to be reading. I'm also assuming I can use these attributes even in supported SDKs?
fair, you shouldn't use it if you're in a supported SDK, although maybe you want? say you just want to record a couple of span attributes yourself.
thanks for looking a this btw!