fix(docs): Prevent CSSStyleSheet error in mermaid diagrams - #19048
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
sergical
approved these changes
Aug 13, 2026
Member
|
good job seer |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DESCRIBE YOUR PR
Tell us what you're changing and why. If your PR resolves an issue, please link it so it closes automatically.
This PR addresses an issue where Mermaid diagrams would crash in certain in-app browsers (e.g., Google iOS app on iPad iOS 16.7.16).
Problem:
Mermaid.js (v11.15.0) attempts to use the
new CSSStyleSheet()constructor (Constructable Stylesheets API) to build theme CSS. This API is not consistently supported across all WebViews, even if the underlying OS version (iOS 16.4+) theoretically supports it in the main browser (Safari). Whennew CSSStyleSheet()throws aTypeError: Illegal constructor, it results in an unhandled error, crashing the diagram rendering and breaking the page for the user.Solution:
try/catchblock aroundnew CSSStyleSheet()at the beginning of therenderMermaidfunction insrc/components/mermaid.tsx. If the constructor throws, the function now returns early, preventing the crash in unsupported environments.mermaid.run()calls in atry/catchblock to gracefully handle any other potential rendering failures from Mermaid.mermaid.run()),setDoneRendering(true)is still called. This ensures that the CSS responsible for hiding the duplicate.darkor.lightmermaid block is applied, leaving a single, readable raw diagram source as a fallback for the user.This change improves the robustness of Mermaid diagram rendering on the docs site, preventing crashes and providing a better user experience in less capable browser environments.
IS YOUR CHANGE URGENT?
Help us prioritize incoming PRs by letting us know when the change needs to go live.
SLA
Thanks in advance for your help!
PRE-MERGE CHECKLIST
Make sure you've checked the following before merging your changes:
LEGAL BOILERPLATE
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. and is gonna need some rights from me in order to utilize my contributions in this here PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.
EXTRA RESOURCES
Fixes DOCS-B2J