Fix mobile file preview switch overflow - #1659
Open
ymichael wants to merge 1 commit into
Open
Conversation
|
🚨 SLOP COP 🚨 · I am SlopCop. I am reviewing this change now. I will check security, code quality, performance, architecture, and the mobile workflow. |
There was a problem hiding this comment.
🚨 SLOP COP 🚨 · review
Plain-English summary
This change makes the Preview/Raw switch fit inside the mobile file header. It sets each inner tab to 30 pixels on narrow touch screens. The border and padding then make the full switch 36 pixels high.
Review
I found no blocking issues.
- Security: The change only uses static CSS classes. It does not change data, URLs, permissions, or code execution.
- Code quality: The local constant removes duplicate classes from the Preview and Raw buttons.
- Performance: The change adds no state, effect, event, request, or repeated layout work.
- Code structure: The codebase has no shared control with the same size and behavior. The local constant is a good fit.
Validation
- A mobile browser test used the exact pull request SHA at 390 by 844 pixels with a coarse pointer.
- The switch and header both measured 36 pixels high. Each tab measured 30 pixels high.
- The switch had no vertical overflow or layout shift.
- The Raw button changed state correctly.
git diff --checkpassed.- All required GitHub checks passed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
pnpm exec turbo run typecheck --filter=@bb/apppnpm exec turbo run test --filter=@bb/app --force(347 files, 2,765 tests)