Skip to content

feature: Github OAuth button placeholder#39

Open
Cragsmann wants to merge 1 commit into
functions-dev:masterfrom
Cragsmann:SRVOCF-862--OAuth-button-placeholder
Open

feature: Github OAuth button placeholder#39
Cragsmann wants to merge 1 commit into
functions-dev:masterfrom
Cragsmann:SRVOCF-862--OAuth-button-placeholder

Conversation

@Cragsmann

@Cragsmann Cragsmann commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Add disabled "Sign in with GitHub" OAuth button with "Coming soon" tooltip to the PAT modal
  • Add "or" divider between OAuth button and PAT input using PF6 Flex layout
  • Move PAT helper text into FormHelperText component (PF6 pattern)

Implements SRVOCF-862

Screenshots

image

Test plan

  • OAuth button renders as disabled with aria-disabled="true"
  • "Coming soon" tooltip appears on hover
  • "or" divider separates OAuth button from PAT input
  • PAT form still works (enter token, connect, error handling)
  • Existing unit tests pass (14/14)

@matejvasek matejvasek requested a review from twoGiants June 15, 2026 09:25
@Cragsmann Cragsmann changed the title SRVOCF-862: Github OAuth button placeholder feature: Github OAuth button placeholder Jun 15, 2026

@twoGiants twoGiants left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewing your first contribution 😸 👍

Add a unit test -> button is there but not clickable so no action is possible.

@Cragsmann

Cragsmann commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator Author

Reviewing your first contribution 😸 👍

Add a unit test -> button is there but not clickable so no action is possible.

thanks for review, As task description says: 'Button placeholder" I thought such test would have meaning after OAuth is completed and button functional.

@Cragsmann Cragsmann requested a review from twoGiants June 15, 2026 10:39
@twoGiants

Copy link
Copy Markdown
Collaborator

Reviewing your first contribution 😸 👍
Add a unit test -> button is there but not clickable so no action is possible.

thanks for review, As task description says: 'Button placeholder" I thought such test would have meaning after OAuth is completed and button functional.

It has meaning now too for the case that the button is removed (by accident) the test will let us know.

@twoGiants twoGiants left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two more things.

  1. Can you get familiar with the process? Ask Matej about it.

    Each "feature" implementation needs an entry for Claude in features.json and claude-progress.json.

    We use those to init claude in a working session so that he knows what was done.

  2. Please remove the link to Jira from the description. I wouldn't link in public Github to our internal Jira tickets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants