NuGet packaging of DesignTime DLL for F# provider#583
Merged
Conversation
Collaborator
Author
|
@T-Gro, I discovered that the design-time DLL is no longer packaged into the NuGet package. |
xperiandri
force-pushed
the
bug/type-provider
branch
from
6fee6bf to
4a3480d
Compare
There was a problem hiding this comment.
Pull request overview
This PR adjusts NuGet packaging for the FSharp.Data.GraphQL.Client type provider so the *.DesignTime.dll is included in the produced package, working around limitations in the F# SDK/MSBuild packing flow when a runtime project references its design-time project via ProjectReference.
Changes:
- Adds a custom target hooked via
TargetsForTfmSpecificContentInPackageto inject the DesignTime DLL into the package. - Removes the previously-used
RemoveUnnecessaryNuGetPackInputtarget and cleans up NuGet-related conditions for consistency. - Updates
ProjectReference/PackageReferenceconditions to use quoted$(IsNuGet)comparisons.
Comment on lines
+46
to
+49
| <MSBuild Projects="@(_DesignTimeProjectRef)" | ||
| Targets="GetTargetPath" | ||
| Properties="Configuration=$(Configuration);TargetFramework=netstandard2.0"> | ||
| <Output TaskParameter="TargetOutputs" ItemName="_DesignTimeDllPath" /> |
xperiandri
force-pushed
the
bug/type-provider
branch
3 times, most recently
from
95a0820 to
79bdced
Compare
Added MSBuild target to ensure DesignTime DLL is included in NuGet package, working around F# SDK limitations with ProjectReference-based providers. Removed obsolete target for cleaning NuGet pack input and updated conditions for consistency.
xperiandri
force-pushed
the
bug/type-provider
branch
from
79bdced to
56419ea
Compare
Test Results 3 files 3 suites 9m 58s ⏱️ Results for commit 56419ea. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added MSBuild target to ensure DesignTime DLL is included in NuGet package, working around F# SDK limitations with ProjectReference-based providers. Removed obsolete target for cleaning NuGet pack input and updated conditions for consistency.