Stage 1A Solution CTRE#34
Open
Spaceman113138 wants to merge 11 commits into
Open
Conversation
ArchdukeTim
suggested changes
Jun 16, 2026
Co-authored-by: Tim Winters <twinters007@gmail.com>
Author
|
@ArchdukeTim is this what you were looking for as far as using timer? |
ArchdukeTim
reviewed
Jun 16, 2026
| */ | ||
| @Override | ||
| public void periodic() { | ||
| if (!autoTimer.hasElapsed(4.0)) { // Drive for 4 seconds after the start of auto |
There was a problem hiding this comment.
Yeah this is better. It might read better if you invert the if statement:
if (hasElapsed(4) {
stop the drivetrain
} else {
drive forward
}
ArchdukeTim
approved these changes
Jun 18, 2026
DylanB5402
requested changes
Jun 18, 2026
DylanB5402
left a comment
DylanB5402
left a comment
Member
There was a problem hiding this comment.
For CTRE, we should use their Sim API directly. You can look at my 2026 version of this PR for reference: #8
I rolled a custom sim impl for REV because their sim is broken right now, but CTRE's should be working
Member
|
@Spaceman113138 we're going to update #24 to be a little more accurate to the actual kitbot - I'll work that out in my PR and we can port them over here after |
Member
|
Can you make the same updates I did in #24 here? rename the mechanisms and update the teleop controls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For #29
Solution for Stage 1A - Mostly a copy of #24 but with formating added and replacing any rev motors with ctre.