Drop pre-32 ScanCode parsing path - #304
Conversation
Require scancode-toolkit>=32.0.2 license_detections only, and simplify matched-text sheet output without the legacy Category column.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
📝 WalkthroughWalkthroughThe ScanCode parsing path now uses one parser entry point. Legacy parser dispatch and legacy-only tests were removed. Matched-license output now uses a single format without the category column. ChangesScanCode parser consolidation
Matched-license output standardization
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@JustinWonjaePark , parsing_scancode_32_earlier 함수를 삭제하는 PR입니다. 최소 ScanCode 32.0.2를 요구하므로 legacy code 삭제하는 사항입니다. |
Drop the version suffix now that only the ScanCode 32+ path remains.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/fosslight_source/_parsing_scancode_file_item.py`:
- Around line 608-611: Add scancode-toolkit>=32.0.2 to the tox test environment
dependencies so the environment running parsing_scancode has the scancode
package available before tests execute. Update the relevant tox configuration
rather than changing _parsing_scancode_file_item.py.
🪄 Autofix
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 65a31126-a106-450e-ba6d-e84ce5eff114
📒 Files selected for processing (3)
src/fosslight_source/_license_matched.pysrc/fosslight_source/_parsing_scancode_file_item.pytests/test_parsing_unknown_spdx.py
Drop the invalid skipdist key so tox.ini matches Tox 4 behavior of installing the current source package and its dependencies.
Require scancode-toolkit>=32.0.2 license_detections only, and simplify matched-text sheet output without the legacy Category column.