Skip to content

Drop pre-32 ScanCode parsing path - #304

Merged
soimkim merged 3 commits into
mainfrom
refactor/drop-pre-32-scancode-parser
Aug 12, 2026
Merged

Drop pre-32 ScanCode parsing path#304
soimkim merged 3 commits into
mainfrom
refactor/drop-pre-32-scancode-parser

Conversation

@soimkim

@soimkim soimkim commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Require scancode-toolkit>=32.0.2 license_detections only, and simplify matched-text sheet output without the legacy Category column.

  • Improvements
    • License reports now use a simplified format without the category column.
    • License entries are presented in a consistent priority and license order.
    • ScanCode results are processed through a unified parsing flow.
    • Improved handling of unknown SPDX identifiers, compound expressions, suppressed findings, custom license references, and parenthesized expressions.

Require scancode-toolkit>=32.0.2 license_detections only, and simplify
matched-text sheet output without the legacy Category column.
@soimkim soimkim self-assigned this Aug 10, 2026
@soimkim soimkim added the chore [PR/Issue] Refactoring, maintenance the code label Aug 10, 2026
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 3b6dd527-0348-4e70-9815-0f978ef17fbc

📥 Commits

Reviewing files that changed from the base of the PR and between 4b25e7e and e7490a6.

📒 Files selected for processing (1)
  • tox.ini
💤 Files with no reviewable changes (1)
  • tox.ini

📝 Walkthrough

Walkthrough

The ScanCode parsing path now uses one parser entry point. Legacy parser dispatch and legacy-only tests were removed. Matched-license output now uses a single format without the category column.

Changes

ScanCode parser consolidation

Layer / File(s) Summary
Unified ScanCode parser
src/fosslight_source/_parsing_scancode_file_item.py, tests/test_parsing_unknown_spdx.py, tox.ini
parsing_file_item now calls parsing_scancode for all inputs. Tests use the unified parser, legacy-only cases were removed, and the global skipdist setting was removed.

Matched-license output standardization

Layer / File(s) Summary
Standardized matched-license output
src/fosslight_source/_license_matched.py
The output header and rows no longer include license categories. Items are sorted by priority, category, and license.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change: removing the pre-32 ScanCode parsing path.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/drop-pre-32-scancode-parser

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@soimkim

soimkim commented Aug 10, 2026

Copy link
Copy Markdown
Contributor Author

@JustinWonjaePark , parsing_scancode_32_earlier 함수를 삭제하는 PR입니다. 최소 ScanCode 32.0.2를 요구하므로 legacy code 삭제하는 사항입니다.
리뷰 후 이상 없다면 Merge 부탁드립니다.

Comment thread src/fosslight_source/_parsing_scancode_file_item.py Outdated
Drop the version suffix now that only the ScanCode 32+ path remains.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@src/fosslight_source/_parsing_scancode_file_item.py`:
- Around line 608-611: Add scancode-toolkit>=32.0.2 to the tox test environment
dependencies so the environment running parsing_scancode has the scancode
package available before tests execute. Update the relevant tox configuration
rather than changing _parsing_scancode_file_item.py.
🪄 Autofix

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 65a31126-a106-450e-ba6d-e84ce5eff114

📥 Commits

Reviewing files that changed from the base of the PR and between ea89cbf and 4b25e7e.

📒 Files selected for processing (3)
  • src/fosslight_source/_license_matched.py
  • src/fosslight_source/_parsing_scancode_file_item.py
  • tests/test_parsing_unknown_spdx.py

Comment thread src/fosslight_source/_parsing_scancode_file_item.py
@soimkim soimkim changed the title refactor: drop pre-32 ScanCode parsing path Drop pre-32 ScanCode parsing path Aug 11, 2026
Drop the invalid skipdist key so tox.ini matches Tox 4 behavior of
installing the current source package and its dependencies.
@soimkim
soimkim merged commit b29c626 into main Aug 12, 2026
8 checks passed
@soimkim
soimkim deleted the refactor/drop-pre-32-scancode-parser branch August 12, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore [PR/Issue] Refactoring, maintenance the code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants