Upload Flytekit runtime metrics to S3#1683
Open
Yicheng-Lu-llll wants to merge 3 commits into
Open
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1683 +/- ##
=======================================
Coverage 71.03% 71.03%
=======================================
Files 336 336
Lines 30798 30813 +15
Branches 5589 5590 +1
=======================================
+ Hits 21876 21889 +13
- Misses 8375 8378 +3
+ Partials 547 546 -1
|
Yicheng-Lu-llll
force-pushed
the
Flytekit-Metrics-Exploration
branch
from
June 13, 2023 22:14
163259e to
9c8c2ee
Compare
Signed-off-by: Yicheng-Lu-llll <luyc58576@gmail.com>
Yicheng-Lu-llll
force-pushed
the
Flytekit-Metrics-Exploration
branch
from
June 14, 2023 01:44
9c8c2ee to
cc51a28
Compare
Yicheng-Lu-llll
marked this pull request as ready for review
June 14, 2023 02:28
Yicheng-Lu-llll
requested review from
cosmicBboy,
eapolinario,
kumare3,
pingsutw and
wild-endeavor
as code owners
June 14, 2023 02:28
This was referenced Jun 24, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TL;DR
This is part of Flytekit Metrics Exploration.
This PR uploads all the flytekit metrics to the remote storage(highlighted in green).

Flytekit Metrics Exploration includes:
flytekit: Upload Flytekit runtime metrics to S3 #1683
flyteplugins: Add GetSpanPath and SpanExists flyteplugins#361
flyteidl: Add span uri flyteidl#415
flytepropeller: Add span uri to node event flytepropeller#577
flyteadmin: Implement GetFlyteKitMetrics endpoint flyteadmin#575
Checks
ran task in the sand box, the span file is under the same folder with deck.html.

