chore: Migrate Symfony XML configuration usage to the PHP one#2449
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2449 +/- ##
============================================
- Coverage 85.11% 85.11% -0.01%
- Complexity 0 21161 +21161
============================================
Files 1599 1599
Lines 65334 65334
============================================
- Hits 55612 55611 -1
- Misses 9722 9723 +1 🚀 New features to boost your workflow:
|
Member
|
Does it work also with 6.4? We are supporting right now 6.4 | 7.4 and 8.0+ |
Member
Author
|
Seems like the new type was added in 7.4, in 6.4 it's still XML one. |
1ae8671 to
a4ebe82
Compare
a4ebe82 to
968904e
Compare
Member
|
hmm let me think about it, we might be able to drop 6.4 entirely |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Symfony deprecated the XML configuration format in release 7.4, and removed it in 8.0. The recommended format is PHP one.
Should fix issues in tests like:
Change Log
Added
Fixed
Changed
Removed
Deprecated
Security