ci: zizmor security checks#23
Open
ndonkoHenri wants to merge 4 commits into
Open
Conversation
Harden the build workflows to pass zizmor (31 findings -> 0 actionable): - Pin every action to a commit SHA at its latest release (setup-python v6.2.0, upload-artifact v7.0.1, download-artifact v8.0.1, gh-release v3.0.0); checkout held at v6.0.3 to match the sibling repos (v7.0.0 is a fresh major — bump all together later). - persist-credentials: false on all checkouts. - Least-privilege top-level permissions: contents: read on build-python.yml (publish-release keeps contents: write). - template-injection: move inputs/env expansions out of run: blocks (incl. the Windows pwsh step -> $env:PYTHON_VERSION). - Drop secrets: inherit on the reusable-workflow call — the child declares no secrets and uses github.token directly. Add .github/workflows/zizmor.yml (official zizmor-action on push/PR -> code scanning, with fork-PR SARIF skip) and .github/dependabot.yml (github-actions, monthly, grouped, 7-day cooldown). Remaining: 1 informational superfluous-actions (softprops/action-gh-release).
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
There was a problem hiding this comment.
Pull request overview
Introduces GitHub Actions security scanning with zizmor and hardens existing CI workflows by tightening permissions and pinning action versions.
Changes:
- Add a new
zizmorworkflow that runs on pushes and PRs and uploads SARIF when permitted. - Harden existing build workflows by setting explicit
permissions, pinning actions to SHAs, and disabling persisted checkout credentials. - Remove
secrets: inheritfrom the reusable workflow invocation.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
.github/workflows/zizmor.yml |
Adds zizmor-based GitHub Actions security analysis with least-privilege permissions. |
.github/workflows/build-python.yml |
Tightens token permissions, pins actions to SHAs, and adjusts release manifest generation. |
.github/workflows/build-python-version.yml |
Pins actions to SHAs, disables persisted credentials, and refines Windows env var usage. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- actions/setup-python: v6.2.0 → v6.3.0 (ece7cb06) - softprops/action-gh-release: v3.0.0 → v3.0.1 (718ea10b) Both SHAs were behind their version comments, triggering zizmor's mismatched-hash-comment audit in GitHub Code Scanning.
|
|
||
| - name: Publish all artifacts to release | ||
| uses: softprops/action-gh-release@v3 | ||
| uses: softprops/action-gh-release@718ea10b132b3b2eba29c1007bb80653f286566b # v3.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.